Re: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use

From: Sergei Shtylyov
Date: Tue Dec 30 2014 - 07:39:57 EST


On 12/30/2014 1:55 PM, Andrew Jackson wrote:

From: Andrew Jackson <Andrew.Jackson@xxxxxxx>

Some I2S clocks may require some time to get the clock ready
for operation and so need to be prepared before they are enabled.
So, prepare the clock as well as enabling it, but combine the
two through clk_prepare_enable.

Signed-off-by: Andrew Jackson <Andrew.Jackson@xxxxxxx>
sound/soc/dwc/designware_i2s.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index 5e9d163..08608c1 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -426,13 +426,16 @@ static int dw_i2s_probe(struct platform_device *pdev)
static int dw_i2s_remove(struct platform_device *pdev)
+ struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev);

Why not just platform_get_drvdata(pdev)?


WBR, Sergei

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at