Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

From: Sergei Shtylyov
Date: Tue Dec 30 2014 - 12:19:04 EST


On 12/30/2014 03:20 PM, Nicholas Mc Guire wrote:

wait_for_completion_timeout does not return negative values so the tests
for <= 0 are not needed and the case differentiation in the error handling
path unnecessary.

I decided to verify your statement and I saw that it seems wrong. do_wait_for_common() can return -ERESTARTSYS and the return value gets returned by its callers unchanged.

patch was only compile tested x86_64_defconfig + CONFIG_ATH_CARDS=m

patch is against linux-next 3.19.0-rc1 -next-20141226

Rather patches. It would have been better to send one patch instead of 4 patches with the same name.

WBR, Sergei

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at