On Tue, Dec 30, 2014 at 11:07:14AM +0800, Chris Zhong wrote:No, when we pull down DVSn pin, the voltage value is from RK808_BUCK1_ON_VSEL_REG,
On 12/30/2014 01:25 AM, Mark Brown wrote:No, I mean that we may as well just always write to the same register
So, this seems a bit odd. What we appear to be doing here isyou mean check the old_selector and selector? I think
alternating between the two different voltage setting registers which is
all well and good but makes me wonder why we're bothering - it's a bit
more work than just sticking with one. We do get...
_regulator_do_set_voltage have done it.
and save a bunch of code.
the spec said 2/4/6/10 mv/us, but the ramp will change depending on the load.Well, that suggests that the spec is wrong which ought to be fixed...this but unless the voltage typically ramps much faster than specActually, it's slower than spec, so I think getting this dvsok pin state
it's never clear to me that we're actually winning by polling the pin
instead of just dead reckoning the time, it's more work for the CPU to
poll the GPIO than to sleep after all.
is safer than delay.
anyway oughtn't it? Or are you saying that the delay is inconsistent as
well as slower than advertised?