Re: [PATCH 0/2] x86: Add IMR support to Quark/Galileo
From: Bryan O'Donoghue
Date: Wed Dec 31 2014 - 06:59:17 EST
On 31/12/14 10:12, Andy Shevchenko wrote:
> On Mon, Dec 29, 2014 at 7:23 PM, Bryan O'Donoghue
> <pure.logic@xxxxxxxxxxxxxxxxx> wrote:
>> This patchset adds an IMR driver to the kernel plus platform code for
>> Intel Galileo Gen1/Gen2 boards.
>> Bryan O'Donoghue (2):
>> x86: Add Isolated Memory Regions for Quark X1000
>> platform/x86 Add Intel Galileo platform specific setup
> I'm going to review this soon, but here few comments below.
>> arch/x86/Kconfig | 23 ++
>> arch/x86/include/asm/imr.h | 79 ++++++
>> arch/x86/include/asm/intel-quark.h | 31 ++
> Could it be just a quark.h? Like for ce4100.
> Those intel- prefixes in the modules looks awkward especially when
> pathname consists x86 already.
Sure thing. I agree there's no real logic to prefixing with intel.
>> arch/x86/kernel/Makefile | 1 +
>> arch/x86/kernel/imr.c | 529 +++++++++++++++++++++++++++++++++++
>> drivers/platform/x86/Kconfig | 15 +
>> drivers/platform/x86/Makefile | 1 +
>> drivers/platform/x86/intel_galileo.c | 175 ++++++++++++
> Here what about to make an hierarchy like:
> intel/mid/... would be those modules with intel_mid_ prefixes in
> future. See my proposal regarding to drivers/mfd 
>> 8 files changed, 854 insertions(+)
>> create mode 100644 arch/x86/include/asm/imr.h
>> create mode 100644 arch/x86/include/asm/intel-quark.h
>> create mode 100644 arch/x86/kernel/imr.c
>> create mode 100644 drivers/platform/x86/intel_galileo.c
>  http://www.spinics.net/lists/kernel/msg1886819.html
That works for me will remember to include for V2.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/