Re: [GIT PULL] Audit fixes for 3.19 #2

From: Al Viro
Date: Wed Dec 31 2014 - 19:02:06 EST


On Wed, Dec 31, 2014 at 05:08:12PM -0500, Paul Moore wrote:

> The getname/putname hacks work in the normal file case, but it falls apart
> when you start talking about AF_UNIX socket files where the filename string
> doesn't go through the getname/putname refcount tricks. In the past (no idea
> how far back this goes off the top of my head) this wasn't an issue since the
> code which recorded the filenames in the audit records was broken, but since
> we just "fixed" that problem, the AF_UNIX socket problem is now making an
> appearance.
>
> At least that is how it looks to me right now, if I'm wrong about this and I'm
> missing an obvious fix I'm all ears/eyes/etc.

Umm... How about just adding a function that would be used instead of
all those
struct filename filename = { .name = name };
and created an object that would be destroyed later by putname()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/