RE: [PATCH] Add VID/PID for HID-type Multi-Touch Module of AFO CO., LTD.

From: kyhw
Date: Tue Jan 06 2015 - 04:28:41 EST


Thanks.

you are right. That's not necessary.
We already processed.

The final purpose of my approach is that the correct working of the AFO
multi-Touch module in All distribution of Linux.
Therefore, the inclusion of the VID,PID(AFO Touch Module) to the
hid-multitouch module is basically needed also for old version of the Linux
distribution.

Ki.

-----Original Message-----
From: Jiri Kosina [mailto:jkosina@xxxxxxx]
Sent: Tuesday, May 20, 2014 11:44 PM
To: YongHwan Ki
Cc: rydberg@xxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx;
linux-kernel@xxxxxxxxxxxxxxx
Subject: RE: [PATCH] Add VID/PID for HID-type Multi-Touch Module of AFO CO.,
LTD.

On Wed, 26 Mar 2014, YongHwan Ki wrote:

> Sorry, I woud like to add the AFO defines in the Linux Kernel.
> No afo defines exists in the current kernel tree.
> I correctly changed the log for adding the afo defines.
>
> Kernel Version : linux-3.14.rc7
> Signed-off-by: Yonghwan Ki <kyhw@xxxxxxxxxx>
>
> diff -uprN -X Documentation/dontdiff ./drivers/hid/hid-core.c
../linux-3.14-rc7m/drivers/hid/hid-core.c
> --- ./drivers/hid/hid-core.c 2014-03-17 10:51:24.000000000 +0900
> +++ ../linux-3.14-rc7m/drivers/hid/hid-core.c 2014-03-21
17:41:51.846939444 +0900
> @@ -1881,6 +1881,8 @@ static const struct hid_device_id hid_ha
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON,
> USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_AFO, USB_DEVICE_ID_AFO_TCM) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_AFO, USB_DEVICE_ID_AFO_THM) },

Is this really necessary? Why doesn't HID_DG_CONTACTID matching work for the
to automatically trigger HID_GROUP_MULTITOUCH-based binding?

--
Jiri Kosina
SUSE Labs


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/