Re: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute

From: Greg Kroah-Hartman
Date: Tue Jan 06 2015 - 12:42:26 EST


On Tue, Jan 06, 2015 at 03:29:56PM +0100, Mariusz Gorski wrote:
> Add new attribute to simplify reading of current temperature.
>
> Signed-off-by: Mariusz Gorski <marius.gorski@xxxxxxxxx>
> ---
> drivers/w1/slaves/w1_therm.c | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)

You add sysfs attributes without adding new Documentation/ABI/ entries,
which means I can't take this patch series, sorry. Please redo it and
add the needed information.

Also, temperature should be a standard sensor attribute, so you might
want to use that subsystem instead of creating your own ABI here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/