Re: [PATCH 1/11] ARM: tegra: add function to control the GPU rail clamp

From: Thierry Reding
Date: Thu Jan 08 2015 - 06:44:55 EST


On Thu, Jan 08, 2015 at 11:39:57AM +0200, Peter De Schrijver wrote:
> > > And specify the dependencies between domains in DT?
> >
> > I think the dependencies could be in the driver. Of course the power
> > domains are per-SoC data, so really shouldn't be in the DTS either (the
> > data is all implied by the compatible value) but there's no good way to
>
> The clock references could also be retrieved via clk_get_sys(). We could add
> some more clkdev entries. If we use the domain name as the dev_id and the
> module names as the con_id's, the domain code could then retrieve the
> clocks by iterating over the module names and performing a
> clk_get_sys(domain_name, module_name) for each module. Unfortunately no such
> mechanism exists for resets.

I don't think having both clock and reset references in the device tree
is all that bad. We could possibly add a lookup mechanism for reset
controls that doesn't rely on DT, but I'm not sure it's really worth it.

Thierry

Attachment: pgp_hFflGeNfx.pgp
Description: PGP signature