Re: [PATCH v3] usb: gadget: ffs: Fix sparse error

From: Felipe Balbi
Date: Thu Jan 08 2015 - 12:03:27 EST


Hi,

On Wed, Dec 24, 2014 at 03:23:07PM +0100, Michal Nazarewicz wrote:
> On Wed, Dec 24 2014, Rohith Seelaboyina wrote:
> > This patch fixes the sparse error in functionfs
> > driver.
> >
> > drivers/usb/gadget/function/f_fs.c:400:44: error: bad
> > constant experssion.
> >
> > Dynamic memory allocation through kcalloc is more safer
> > than declaring variable array size, Fix this error by
> > using kcalloc for memory allocation, Check if memory
> > allocation is successful and return -ENOMEM on failure.
> >
> > Signed-off-by: Rohith Seelaboyina <rseelaboyina@xxxxxxxxxx>
>
> This has already been addressed in a way that does not require dynamic
> allocation: <https://lkml.org/lkml/2014/9/10/513>. I'd rather patch
> attached at the end would be applied.

can you send below as a proper patch ?

thanks

--
balbi

Attachment: signature.asc
Description: Digital signature