Re: [PATCH v2 3/8] ARM: digicolor: add minimal device tree description

From: Arnd Bergmann
Date: Thu Jan 08 2015 - 17:42:42 EST


On Thursday 08 January 2015 21:39:59 Baruch Siach wrote:
> +
> + chosen {
> + bootargs = "console=ttyS0,115200 earlyprintk";
> + };
> +};

Please don't put earlyprintk into the dtb. Hopefully by the next
merge window we will have working earlycon support as a replacement.
You can already put an stdout-path property into the chosen node
for this.

> + interrupt-parent = <&intc>;
> +
> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + };

Better move the aliases into the board specific file.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/