[PATCH] livepatch: fix deferred module patching order

From: Josh Poimboeuf
Date: Fri Jan 09 2015 - 15:03:19 EST


When applying multiple patches to a module, if the module is loaded
after the patches are loaded, the patches are applied in reverse order:

$ insmod patch1.ko
[ 43.172992] livepatch: enabling patch 'patch1'

$ insmod patch2.ko
[ 46.571563] livepatch: enabling patch 'patch2'

$ modprobe nfsd
[ 52.888922] livepatch: applying patch 'patch2' to loading module 'nfsd'
[ 52.899847] livepatch: applying patch 'patch1' to loading module 'nfsd'

Fix the loading order by storing the klp_patches list in queue order.

Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
---
kernel/livepatch/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index ce42d3b..3d9c00b 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -739,7 +739,7 @@ static int klp_init_patch(struct klp_patch *patch)
goto free;
}

- list_add(&patch->list, &klp_patches);
+ list_add_tail(&patch->list, &klp_patches);

mutex_unlock(&klp_mutex);

--
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/