Re: [PATCH] staging:vt6655 Add extern variable in head file

From: Greg Kroah-Hartman
Date: Tue Jan 13 2015 - 01:02:01 EST


On Tue, Dec 16, 2014 at 03:39:50PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@xxxxxxxxx>
>
> Subject: [PATCH] staging:vt6655 Add extern variable in head file

Why is this in the middle of the patch? I would have to hand edit it
out :(

>
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.

Always wrap your changelog at 72 columns.

Please fix up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/