Re: [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default

From: Michael Ellerman
Date: Tue Jan 13 2015 - 18:44:37 EST


On Tue, 2015-01-13 at 08:22 -0700, Shuah Khan wrote:
> On 01/13/2015 03:22 AM, Anshuman Khandual wrote:
> > This patch adds a test case for the system wide DSCR default
> > value, which when changed through it's sysfs interface must
> > be visible to all threads reading DSCR either through the
> > privilege state SPR or the problem state SPR. The DSCR value
> > change should be immediate as well.
> >
> > Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> > ---
> > tools/testing/selftests/powerpc/Makefile | 2 +-
> > tools/testing/selftests/powerpc/dscr/Makefile | 17 +++
> > tools/testing/selftests/powerpc/dscr/dscr.h | 120 ++++++++++++++++++++
> > .../selftests/powerpc/dscr/dscr_default_test.c | 121 +++++++++++++++++++++
> > 4 files changed, 259 insertions(+), 1 deletion(-)
> > create mode 100644 tools/testing/selftests/powerpc/dscr/Makefile
> > create mode 100644 tools/testing/selftests/powerpc/dscr/dscr.h
> > create mode 100644 tools/testing/selftests/powerpc/dscr/dscr_default_test.c
>
> Could you please add a .gitignore for powerpc targets as we
> discussed earlier. It can be separate patch.

I can do that.

> Also, I would like to see the test results reports using
> kselftest.h - it can be separate patch in the interest of
> getting tests in.

Sorry but kselftest.h doesn't do anything useful for us.

We have existing test reporting that uses the subunit protocol.

I'm happy to convert that to TAP, or some other well defined output format, but
not to something ad-hoc like kselftest.h currently provides.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/