Re: [PATCH v2 1/1] atm: remove deprecated use of pci api

From: chas williams - CONTRACTOR
Date: Wed Jan 14 2015 - 08:59:19 EST


On Tue, 13 Jan 2015 21:59:44 -0500 (EST)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: Quentin Lambert <lambert.quentin@xxxxxxxxx>
> Date: Mon, 12 Jan 2015 17:10:42 +0100
>
> > @@ -2246,7 +2246,8 @@ static int eni_init_one(struct pci_dev *pci_dev,
> > goto err_disable;
> >
> > zero = &eni_dev->zero;
> > - zero->addr = pci_alloc_consistent(pci_dev, ENI_ZEROES_SIZE, &zero->dma);
> > + zero->addr = dma_alloc_coherent(&pci_dev->dev, ENI_ZEROES_SIZE,
> > + &zero->dma, GFP_ATOMIC);
> > if (!zero->addr)
> > goto err_kfree;
> >
>
> I really would like you to look at these locations and see if
> GFP_KERNEL can be used instead of GFP_ATOMIC. I bet that nearly
> all of these can, and it is preferred.
>
> Thanks.

I think I would like to go through and just fix all the usages of the
older pci interface. This patch isn't very complete due to its
automated nature.

I will make some time this weekend.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/