Re: [PATCH] drm/radeon/radeon_fb: Remove unused function

From: Alex Deucher
Date: Wed Jan 14 2015 - 16:44:57 EST


On Tue, Jan 13, 2015 at 2:02 PM, Rickard Strandqvist
<rickard_strandqvist@xxxxxxxxxxxxxxxxxx> wrote:
> Remove the function radeon_fbdev_total_size() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>

Applied. thanks!

Alex

> ---
> drivers/gpu/drm/radeon/radeon_fb.c | 10 ----------
> drivers/gpu/drm/radeon/radeon_mode.h | 1 -
> 2 files changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> index 0ea1db8..76adbdb 100644
> --- a/drivers/gpu/drm/radeon/radeon_fb.c
> +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> @@ -389,16 +389,6 @@ void radeon_fbdev_set_suspend(struct radeon_device *rdev, int state)
> fb_set_suspend(rdev->mode_info.rfbdev->helper.fbdev, state);
> }
>
> -int radeon_fbdev_total_size(struct radeon_device *rdev)
> -{
> - struct radeon_bo *robj;
> - int size = 0;
> -
> - robj = gem_to_radeon_bo(rdev->mode_info.rfbdev->rfb.obj);
> - size += radeon_bo_size(robj);
> - return size;
> -}
> -
> bool radeon_fbdev_robj_is_fb(struct radeon_device *rdev, struct radeon_bo *robj)
> {
> if (robj == gem_to_radeon_bo(rdev->mode_info.rfbdev->rfb.obj))
> diff --git a/drivers/gpu/drm/radeon/radeon_mode.h b/drivers/gpu/drm/radeon/radeon_mode.h
> index 04db2fd..ec2014a 100644
> --- a/drivers/gpu/drm/radeon/radeon_mode.h
> +++ b/drivers/gpu/drm/radeon/radeon_mode.h
> @@ -915,7 +915,6 @@ void dce8_program_fmt(struct drm_encoder *encoder);
> int radeon_fbdev_init(struct radeon_device *rdev);
> void radeon_fbdev_fini(struct radeon_device *rdev);
> void radeon_fbdev_set_suspend(struct radeon_device *rdev, int state);
> -int radeon_fbdev_total_size(struct radeon_device *rdev);
> bool radeon_fbdev_robj_is_fb(struct radeon_device *rdev, struct radeon_bo *robj);
>
> void radeon_fb_output_poll_changed(struct radeon_device *rdev);
> --
> 1.7.10.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/