Re: [PATCH v3 7/8] clocksource: atmel-st: use syscon/regmap

From: Alexandre Belloni
Date: Thu Jan 15 2015 - 12:02:43 EST


On 15/01/2015 at 17:40:37 +0100, Daniel Lezcano wrote :
> > /*
> >@@ -234,13 +201,21 @@ err:
> > */
> > static void __init atmel_st_timer_init(struct device_node *node)
> > {
> >- /* For device tree enabled device: initialize here */
> >- of_at91rm9200_st_init();
> >+ unsigned int val;
> >+
> >+ regmap_st = syscon_node_to_regmap(node);
> >+ if (IS_ERR(regmap_st))
> >+ panic(pr_fmt("Unable to get regmap\n"));
>
> Is it possible to get ride of those panics ? IIRC, we discussed to not panic
> when a timer was not initialized in case there is a definition for another
> one.
>

Ok, I'll remove those.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/