Re: [PATCH v2 04/11] ARM: tegra: Set spi-max-frequency property to flash node

From: Stephen Warren
Date: Thu Jan 15 2015 - 12:25:37 EST


On 01/15/2015 09:12 AM, Tomeu Vizoso wrote:
To silence a warning on Nyan boards.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>
---
arch/arm/boot/dts/tegra124-nyan-big.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index 9a9cffe..94c7ba9 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -1660,6 +1660,7 @@

flash@0 {
compatible = "winbond,w25q32dw";
+ spi-max-frequency = <25000000>;

This property already exists in the SPI controller. Isn't the max frequency supposed to inherit from there? If so, shouldn't the code not warn when such inheritance happens, i.e. it'd be better to fix the code?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/