Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU

[David Daney]

On 01/15/2015 11:53 AM, Aaro Koskinen wrote:
> Hi,
>
> On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote:
> > On 01/15/2015 10:49 AM, Aaro Koskinen wrote:
> > > octeon_cpu_disable() will unconditionally enable interrupts when called
> > > with interrupts disabled. Fix that.
> >
> > interrupts are always disabled here, so...
>
> Is that also true for all the currently supported stable kernels...?

I haven't done extensive research recently, but I have removed that pair 
of local_irq_disable/local_irq_enable in our SDK kernel based on 3.10


> Or should I just drop Cc: stable from this patch?
>
> > Just remove this...
> >
> > >   	octeon_fixup_irqs();
> > > -	local_irq_enable();
> > > +	local_irq_restore(flags);
> >
> > ... and this.
> >
> > >   	flush_cache_all();
> > >   	local_flush_tlb_all();
> >
> > You can add an Acked-by me if you do that.
>
> Ok, I will do that.
>
> A.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/