Re: [PATCH RFC 5/6] epoll: Add implementation for epoll_mod_wait

From: Paolo Bonzini
Date: Wed Jan 21 2015 - 05:36:02 EST




On 21/01/2015 08:52, Michael Kerrisk (man-pages) wrote:
>> > The problem is that there is no room for flags field in epoll_pwait1, which is
>> > asked for, in previous discussion thread [1].
> Ahh yes, I certainly should not have forgotten that. But that's easily solved.
> Do as for pselect6():
>
> strcut sigargs {
> const sigset_t *ss;
> size_t ss_len; /* Size (in bytes) of object pointed
> to by 'ss' */
> }
>
> epoll_pwait1(int epfd, struct epoll_event *events, int maxevents,
> struct timespec *timeout, int clock_id, int flags,
> int timeout,
> const struct sigargs *sargs);
>

Alternatively, place the clock_id in the lower 16 bits of flags.
MAX_CLOCKS is 16 right now, so there's room.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/