Re: [PATCH] x86, e820: clean up around sanitize_e820_map()

[WANG Chao]

Hi, David

On 01/21/15 at 02:51pm, David Rientjes wrote:
> On Wed, 7 Jan 2015, WANG Chao wrote:
> 
> > The argument 3 of sanitize_e820_map() will only update upon a successful
> > sanitization. Some of the callers may not be aware of this in the past.
> > Now clean up these callers.
> > 
> > Signed-off-by: WANG Chao <chaowang@xxxxxxxxxx>
> 
> Nice, but it's incomplete: it should also cleanup 
> default_machine_specific_memory_setup().

default_machine_specific_memory_setup() is special. Because
boot_params.e820_entries is 8bit unsigned, and sanitize_e820_map() which
takes 32bit unsigned, will step on other member of boot_params next to
e820_entries.

Thanks
WANG Chao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/