Re: [Xen-devel] [RFC v3 2/2] x86/xen: allow privcmd hypercalls to be preempted

From: Andrew Cooper
Date: Thu Jan 22 2015 - 06:50:25 EST


On 22/01/15 02:17, Luis R. Rodriguez wrote:
> --- a/drivers/xen/events/events_base.c
> +++ b/drivers/xen/events/events_base.c
> @@ -32,6 +32,8 @@
> #include <linux/slab.h>
> #include <linux/irqnr.h>
> #include <linux/pci.h>
> +#include <linux/sched.h>
> +#include <linux/kprobes.h>
>
> #ifdef CONFIG_X86
> #include <asm/desc.h>
> @@ -1243,6 +1245,17 @@ void xen_evtchn_do_upcall(struct pt_regs *regs)
> set_irq_regs(old_regs);
> }
>
> +notrace void xen_end_upcall(struct pt_regs *regs)
> +{
> + if (!xen_is_preemptible_hypercall(regs) ||
> + __this_cpu_read(xed_nesting_count))
> + return;
> +
> + if (_cond_resched())
> + printk(KERN_DEBUG "xen hypercall preempted\n");

I wouldn't even put this at debug level. On a large server with plenty
of domains being created/migrated/destroyed, it is quite likely that a
toolstack task might get preempted in this way.

I don't believe the message is of any practical use.

~Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/