Re: [PATCH v6 5/7] sched/fair: fix idle balance when remaining tasks are all non-CFS tasks

From: Tim Chen
Date: Thu Jan 22 2015 - 13:15:34 EST


On Thu, 2015-01-22 at 12:05 +0800, Wanpeng Li wrote:
> On Tue, Jan 20, 2015 at 07:18:37AM +0800, Wanpeng Li wrote:
> >>> if (!rq->rd->overload)
> >>> rq->rd->overload = true;
> >>
> >>Here 3882ec643997 ("nohz: Use IPI implicit full barrier against
> >>rq->nr_running r/w") might be a clue.
> >>
> >>Also, this is wrong, it breaks NOHZ_FULL.
> >
> >Got it. If the modification in update_sg_lb_stats of my patch is still
> >corrrect, if so I can send out a new version.
>
> Ping,
>

Hard to respond without seeing your new patch.

Tim

> >
> >Regards,
> >Wanpeng Li


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/