Re: [RFC PATCH] sched, timer: Use atomics for thread_group_cputimer stats

From: Peter Zijlstra
Date: Fri Jan 23 2015 - 04:33:48 EST


> + .running = ATOMIC_INIT(0), \
> + atomic_t running;
> + atomic_set(&sig->cputimer.running, 1);
> @@ -174,7 +174,7 @@ static inline bool cputimer_running(struct task_struct *tsk)
> + if (!atomic_read(&cputimer->running))
> + if (!atomic_read(&cputimer->running)) {
> + atomic_set(&cputimer->running, 1);
> + if (atomic_read(&tsk->signal->cputimer.running))
> + atomic_set(&cputimer->running, 0);
> + if (atomic_read(&sig->cputimer.running)) {
> + if (atomic_read(&tsk->signal->cputimer.running))

That doesn't really need an atomic_t.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/