Re: [PATCH RESEND] mmc: mmci: Get rid of dead code in mmci_dma_setup

From: Ulf Hansson
Date: Fri Jan 23 2015 - 07:08:15 EST


On 21 January 2015 at 11:17, Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx> wrote:
> DMA configuration has been removed from function mmci_dma_setup but the
> local mask variable was not removed. This remains unused hence remove
> it from the function and operations on it
>
> Signed-off-by: Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx>

Thanks! Applied for next.

Kind regards
Uffe

> ---
> drivers/mmc/host/mmci.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index 47dcece..122a751 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -435,7 +435,6 @@ static void mmci_init_sg(struct mmci_host *host, struct mmc_data *data)
> static void mmci_dma_setup(struct mmci_host *host)
> {
> const char *rxname, *txname;
> - dma_cap_mask_t mask;
> struct variant_data *variant = host->variant;
>
> host->dma_rx_channel = dma_request_slave_channel(mmc_dev(host->mmc), "rx");
> @@ -444,10 +443,6 @@ static void mmci_dma_setup(struct mmci_host *host)
> /* initialize pre request cookie */
> host->next_data.cookie = 1;
>
> - /* Try to acquire a generic DMA engine slave channel */
> - dma_cap_zero(mask);
> - dma_cap_set(DMA_SLAVE, mask);
> -
> /*
> * If only an RX channel is specified, the driver will
> * attempt to use it bidirectionally, however if it is
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/