Re: [PATCH V4 2/2] i2c-designware: Add Intel Baytrail PMIC I2C bus support

From: Wolfram Sang
Date: Fri Jan 23 2015 - 09:19:20 EST



Mostly good, except one thing:

> +config I2C_DESIGNWARE_BAYTRAIL
> + bool "Intel Baytrail I2C semaphore support"
> + depends on I2C_DESIGNWARE_PLATFORM
> + select IOSF_MBI

This needs some dependency on something Baytrail specific. Otherwise, it
causes lots of build errors:

With ARM allnoconfig, I can select this option but there are no headers
for iosf.

With x86_64_defconfig and disabled ACPI, I can select this option but it
fails over "implicit declaration of function âacpi_evaluate_integerâ".

An incremental patch will do for me, the rest looks good.

Attachment: signature.asc
Description: Digital signature