Re: [PATCH] staging: rtl8192u: r8192U_core: Fix compile issue when CONFIG_WIRELESS_EXT is not defined

[Greg KH]

On Sat, Jan 24, 2015 at 05:11:42PM -0200, Murilo Opsfelder Araujo wrote:
> This patch gets rid of the following error when compiling r8192U_core.c
> and CONFIG_WIRELESS_EXT is not defined:
> 
> drivers/staging/rtl8192u/r8192U_core.c: In function ârtl8192_usb_probeâ:
> drivers/staging/rtl8192u/r8192U_core.c:4697:5: error: âstruct net_deviceâ has no member named âwireless_handlersâ
>   dev->wireless_handlers = (struct iw_handler_def *) &r8192_wx_handlers_def;
>      ^
> 
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@xxxxxxxxx>
> ---
>  drivers/staging/rtl8192u/r8192U_core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index e031a25..396a11f 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -4694,7 +4694,9 @@ static int rtl8192_usb_probe(struct usb_interface *intf,
>  
>  	dev->netdev_ops = &rtl8192_netdev_ops;
>  
> +#ifdef CONFIG_WIRELESS_EXT
>  	dev->wireless_handlers = (struct iw_handler_def *) &r8192_wx_handlers_def;
> +#endif

It's almost never correct to put a #ifdef in a .c file, so what is going
on here?  How do other drivers handle this in a more "proper" way?

Is this something new?  Should this driver just depend on this Kconfig
option?

I can't take this as-is, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/