Re: [PATCH 1/4] staging: vt6655: correcting function declaration sparse error

[Greg KH]

On Sat, Jan 17, 2015 at 07:04:23PM -0700, mathieu.poirier@xxxxxxxxxx wrote:
> From: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> 
> mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/
>   LD      drivers/staging/vt6655/built-in.o
>   CHECK   drivers/staging/vt6655/device_main.c
> drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static?
>   CC [M]  drivers/staging/vt6655/device_main.o
> 
> Function @vnt_init is only called by @vt6655_probe, in turn is declared "static".
> As sparse suggest, @vnt_init should very likely be declared static as well.  At
> least nothing in the file indicate that it should be otherwise.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> ---
>  drivers/staging/vt6655/device_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This whole series does not apply to my staging-next branch, of
staging.git, please refresh against it and resend if it is still needed
(hint, I don't think they all are...)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/