Re: [PATCH v3 1/1] x86: Add Isolated Memory Regions for Quark X1000

[Bryan O'Donoghue]

On 26/01/15 16:37, Andy Shevchenko wrote:

> > +config X86_INTEL_QUARK
> > +       bool "Intel Quark platform support"
> > +       depends on X86_32
> > +       depends on X86_EXTENDED_PLATFORM
> > +       depends on X86_PLATFORM_DEVICES
> > +       depends on PCI
> > +       depends on PCI_GOANY
> > +       depends on X86_IO_APIC
> > +       select IOSF_MBI
> > +       select INTEL_IMR
> > +       ---help---
> > +         Select to include support for Quark X1000 SoC.
> > +         Say Y here if you have a Quark based system such as the Arduino
> > +         compatible Intel Galileo.
> > +
>
> Does it mean we introduce a minimal support for the platform.

I'd call it minimal support yes since the IMR memory map needs to be 
sanitized before you run DMA.

All shipping versions of Galileo will need to have IMRs sanitized to 
reliably run Linux - or any other kernel for that matter - with DMA.

> So, I mean if user enables this in the kernel config and runs rebuilt
> kernel on the Quark it will work, will it?

Yes. Do you mean to add a stronger comment indicating IMR is mandatory ?
No issue with that.

> If so, IMR is mandatory stuff or not? What else is mandatory?

IMR is the only mandatory addition.

> So, I'm not sure the above is a part of the patch. Would it be a prepend?

Hmm - what do you mean by that ?

<snip>

No issue with the rest of the review - thanks for the time.

--
BOD
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/