Re: [PATCH] net: Linn Ethernet Packet Sniffer driver

[Joe Perches]

On Mon, 2015-01-26 at 11:11 +0000, Stathis Voukelatos wrote:
> On 24/01/15 21:37, Joe Perches wrote:
> > On Fri, 2015-01-23 at 10:07 +0000, Stathis Voukelatos wrote:
> >> This patch adds support the Ethernet Packet Sniffer H/W module
> >> developed by Linn Products Ltd and found in the IMG Pistachio SoC.
> >> The module allows Ethernet packets to be parsed, matched against
> >> a user-defined pattern and timestamped. It sits between a 100M
> >> Ethernet MAC and PHY and is completely passive with respect to
> >> Ethernet frames.
> > []
> >>   include/linux/pkt_sniffer.h                        |  89 +++++
> > Why should this file be here?
> > Why not in the drivers/net/pkt-sniffer directory?
[]
> This header file is the public API for the driver.
> Should it not live under the 'include' directory?
> Several other drivers seem to follow that convention.

It depends on how public is public.

If it's _really_ public, it should be in uapi.
If it's kinda public, then _maybe_ it should be
in include/linux, but how likely is it another
driver will use it?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/