Re: [PATCH] pinctrl: qcom: enable generic support and input-enable pinctrl conf

From: Stephen Boyd
Date: Mon Jan 26 2015 - 20:23:49 EST


On 01/26/15 17:18, Stephen Boyd wrote:
> On 01/26/15 08:24, Stanimir Varbanov wrote:
>
>> return -ENOTSUPP;
>> }
>>
>> @@ -208,14 +208,12 @@ static int msm_config_get(struct pinctrl_dev *pctldev,
>> unsigned int pin,
>> unsigned long *config)
>> {
>> - dev_err(pctldev->dev, "pin_config_set op not supported\n");
> Same for here.
>
>> return -ENOTSUPP;
>> }
>>
>> static int msm_config_set(struct pinctrl_dev *pctldev, unsigned int pin,
>> unsigned long *configs, unsigned num_configs)
>> {
>> - dev_err(pctldev->dev, "pin_config_set op not supported\n");
> And here.

Actually it looks like we can just remove these two functions and the
core does the right thing and prints errors. That would be a good patch.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/