[PATCH] usb: phy-generic: Don't fail on missing gpio reset

From: Soren Brinkmann
Date: Mon Jan 26 2015 - 20:45:48 EST


A reset through a GPIO is optional. Don't fail probing when it is
missing.

Reported-by: Andreas FÃrber <afaerber@xxxxxxx>
Signed-off-by: Soren Brinkmann <soren.brinkmann@xxxxxxxxxx>
---
Hi Andreas,

does this do the trick?

Thanks,
SÃren

drivers/usb/phy/phy-generic.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c
index dd05254241fb..a73d4c738f0b 100644
--- a/drivers/usb/phy/phy-generic.c
+++ b/drivers/usb/phy/phy-generic.c
@@ -241,10 +241,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop,

if (err == -EPROBE_DEFER)
return -EPROBE_DEFER;
- if (err) {
- dev_err(dev, "Error requesting RESET GPIO\n");
- return err;
- }
+ if (err)
+ nop->gpiod_reset = NULL;

nop->phy.otg = devm_kzalloc(dev, sizeof(*nop->phy.otg),
GFP_KERNEL);
--
2.2.2.1.g63c5777

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/