RE: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

[Yang, Wenyou]

Hi Sylvain,

Thanks a lot.

> -----Original Message-----
> From: Sylvain Rochet [mailto:sylvain.rochet@xxxxxxxxxxxx]
> Sent: Tuesday, January 27, 2015 6:08 PM
> To: Yang, Wenyou
> Cc: Ferre, Nicolas; linux@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; alexandre.belloni@xxxxxxxxxxxxxxxxxx;
> peda@xxxxxxxxxx; sergei.shtylyov@xxxxxxxxxxxxxxxxxx; linux@xxxxxxxxxxxx
> Subject: Re: [PATCH v3 08/13] pm: at91: the standby mode uses the same sram
> function as the suspend to memory mode
> 
> Hello Wenyou,
> 
> On Tue, Jan 27, 2015 at 01:58:20PM +0800, Wenyou Yang wrote:
> >
> > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index
> > 0377c0d..d967c31 100644
> > --- a/arch/arm/mach-at91/pm.c
> > +++ b/arch/arm/mach-at91/pm.c
> > @@ -71,7 +71,7 @@ static int at91_pm_begin(suspend_state_t state)
> >   * Verify that all the clocks are correct before entering
> >   * slow-clock mode.
> >   */
> > -static int at91_pm_verify_clocks(void)
> > +static int at91_pm_verify_clocks(suspend_state_t state)
> >  {
> >  	unsigned long scsr;
> >  	int i;
> > @@ (...)
> 
> Unused state argument, it was added in v2, this is just a trace of a reverted v2
> change not fully cleaned.

Yes, not clear.
> 
> 
> > +		if (!at91_pm_verify_clocks(state))
> > +			goto error;
> 
> Ditto.
> 
> 
> Sylvain

Best Regards,
Wenyou Yang