Re: [PATCH] samsung-laptop: enable better lid handling

[Julijonas Kikutis]

> > However, a user with another laptop in the bug report says that
"power
> > button has to be pressed twice to wake the machine" in this mode.
> 
> This is with this patch applied?

No, the commenter in bugzilla reports that it happened after manually
outputting the command to debugfs. Of course, the same command is used
by this patch only if the sysfs attribute is enabled.

> > This mode is also needed in UEFI, but there samsung-laptop is
> > unfortunately disabled.
> 
> I don't follow. What are you saying here?

samsung_init returns -ENODEV if the computer boots in UEFI. Some
functionality (e.g. the battery saving mode, SABI access for this lid
handling issue, some LED functionality for other laptops) have no
alternative ways to be accessed without this module. But this issue is
only tangentially related to my patch.

> This can be one line.

I have sent the revised patch as a reply to the first patch.

Thank you.
Julijonas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/