Re: [PATCH 3/3] x86,fpu: use disable_task_lazy_fpu_restore helper

From: Rik van Riel
Date: Mon Feb 02 2015 - 12:56:34 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/30/2015 04:46 PM, Dave Hansen wrote:
> On 01/30/2015 09:49 AM, riel@xxxxxxxxxx wrote:
>> @@ -440,8 +440,9 @@ static inline fpu_switch_t
>> switch_fpu_prepare(struct task_struct *old, struct ta
>> new->thread.fpu_counter > 5); if (__thread_has_fpu(old)) { if
>> (!__save_init_fpu(old)) - cpu = ~0; - old->thread.fpu.last_cpu
>> = cpu; + task_disable_lazy_fpu_restore(old); + else +
>> old->thread.fpu.last_cpu = cpu;
>
> What is the 'else' doing here? It seems a bit disconnected from
> the other parts of the patch.

Let me break that out into a separate patch, for reviewing
clarity.

INCOMING!

- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUz7o7AAoJEM553pKExN6DekMIAIuAFk437HUVDviJX9tx8his
2Jec8932I2+nd8OBzqBdCjiSUimLCNdT7eygf2UUdMciaNuHQ1CU1GAkM2MOglvo
/ZYAGoZPbqdJZOQZp0HIzpqBGaqTjNoNfY46EVZyQgc/e3LVAfMZEF/SHhjLESEt
gaJ0/ucRxl8a5C4qd29Pdgbn6jaionmEA1xrdYqfvQM32JVt4B7Qu/v2ZVCWDsCt
W+TIEWFJga7u6vtKkfC4eHB0PPliMTn0N5bzCSk4zGZRtj+T8rVJ1eFcxhmEsWFs
N6EF5CwGMVU0QvsWHK6Js2ELHAo+I1KJ7e/m0dHeBj/P4To835tnMh3a+IK0XWo=
=rIwr
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/