Re: [Patch v2 00/23] Improve ACPI resource parsing interfaces and enable IOAPIC hotplug

From: Rafael J. Wysocki
Date: Wed Feb 04 2015 - 08:08:10 EST


On Wednesday, February 04, 2015 01:32:14 PM Jiang Liu wrote:
>
> On 2015/2/4 5:54, Rafael J. Wysocki wrote:
> > On Monday, February 02, 2015 10:42:45 AM Jiang Liu wrote:
> >> During enabling ACPI based IOAPIC hotplug, Thomas noticed some issues
> >> in ACPI resource parsing interfaces. So this is an effort to improve them.
> >>
> >> Patch 1 refines ACPICA resource descriptors, which has already been
> >> merged into "git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge"
> >>
> >> Patch 2-12 improve ACPI resource parsing interfaces and also fixes some
> >> bugs.
> >>
> >> Patch 13-20 try to share the common data structure resource_list_entry
> >> between PCI and ACPI. It may also be shared with PNP too.
> >>
> >> Patch 21-23 enable ACPI based IOAPIC hotplug.
> >>
> >> The patchset is based on v3.19-rc6+ and passed Fengguang's 0day test
> >> suite. You may get it from:
> >> https://github.com/jiangliu/linux.git acpires_v2
> >
> > Patch [1/23] has been in linux-next for a while already.
> >
> > I've just queued up patches [2-20/23] for 3.20.
> >
> > I have some questions to patch [21/23] which I'll ask in a reply to that one.
> >
> > If [22-23/23] do not depend on [21/23] in any way, I can queue them up too, so
> > please let me know if that's the case.
> Yes, we could apply all other patches without 21/23.

Well, there seems to be a problem with patch [17/23]. Namely, it looks like
one of the commits in the PCI tree introduces struct resource_list_entry for
DT which then fails to compile when your patch [17/23] is merged. I'm yet
to confirm that, but would there be a problem to send an updated version of
patch [17/23] with the new type called "struct resource_entry" instead?
It doesn't look like the "list" part of the type name is really essential
here.


--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/