Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

From: Sergei Shtylyov
Date: Wed Feb 04 2015 - 17:04:25 EST


Hello.

On 02/05/2015 01:01 AM, Mike Turquette wrote:

Anyone may call clk_round_rate() with a zero rate value, so we have to
protect against that.

Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

I agree that this should not be fixed in the core because the fixup is
really driver dependant.

Dunno, zero frequency seems generally insane to me.

It is useful to find the lowest frequency a clock can support. Basically
it is a search for the floor frequency.

Why not just use 1? Or are you assuming that some hardware could actually support 0 Hz?

Regards,
Mike

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/