Re: [PATCH] net/macb: fix sparse warning

[Lad, Prabhakar]

On Thu, Feb 5, 2015 at 4:06 PM, Nicolas Ferre <nicolas.ferre@xxxxxxxxx> wrote:
> Le 05/02/2015 16:40, Lad Prabhakar a Ãcrit :
>> From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>
>>
>> this patch fixes following sparse warning:
>>
>> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static?
>
> Well, actually this function doesn't need to be exported and indeed
> should be marked as static.
>
> I'm not against this patch, but removing the export macro and making it
> as static should do the trick even better.
>
Done!

[1] https://patchwork.kernel.org/patch/5785511/

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/