[PATCH] edac: fix memory leaks on failure path in edac_init()

From: Alexey Khoroshilov
Date: Fri Feb 06 2015 - 01:13:06 EST


edac_init() does not deallocate already allocated resources on failure path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
---
drivers/edac/edac_module.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c
index e6d1691dfa45..a256dcb31d03 100644
--- a/drivers/edac/edac_module.c
+++ b/drivers/edac/edac_module.c
@@ -112,7 +112,7 @@ static int __init edac_init(void)

err = edac_mc_sysfs_init();
if (err)
- goto error;
+ goto err_sysfs;

edac_debugfs_init();

@@ -120,12 +120,15 @@ static int __init edac_init(void)
err = edac_workqueue_setup();
if (err) {
edac_printk(KERN_ERR, EDAC_MC, "init WorkQueue failure\n");
- goto error;
+ goto err_wq;
}

return 0;

-error:
+err_wq:
+ edac_debugfs_exit();
+ edac_mc_sysfs_exit();
+err_sysfs:
return err;
}

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/