RE: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim

From: Chao Yu
Date: Fri Feb 06 2015 - 03:21:49 EST


Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@xxxxxxxxxx]
> Sent: Friday, February 06, 2015 2:19 PM
> To: Chao Yu
> Cc: 'Changman Lee'; linux-fsdevel@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [f2fs-dev] [PATCH 5/5 v4] f2fs: introduce a batched trim
>
> Hi Chao,
>
> Something like this?
>
> Change log from v3:
> o align to section size
>
> This patch introduces a batched trimming feature, which submits split discard
> commands.
>
> This is to avoid long latency due to huge trim commands.
> If fstrim was triggered ranging from 0 to the end of device, we should lock
> all the checkpoint-related mutexes, resulting in very long latency.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

Looks good to me.

Reviewed-by: Chao Yu <chao2.yu@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/