Re: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline

From: Borislav Petkov
Date: Fri Feb 06 2015 - 05:49:52 EST


On Fri, Feb 06, 2015 at 01:00:12AM -0500, Parmeshwr Prasad wrote:
> I am really sorry that I could not mentioned for what purpose this patch is .
> I wanted this patch to be included along with your patch. As your patch is
> To add âdebugâ cmdline in efi=â<option>â.
>
> There are some messages in efifb which appears while booting. I thought of
> Putting that messages under efi=âdebugâ cmdline. When efi=debug is given
> Then only efifb messages should appear.

This is not how we do patches. If you feel that those printks in efifb
are too verbose and should be behind a debug switch or, even removed
completely, you can do a separate patch as I explained to you and write
in that commit message what needs to be done and *why* you think it
should be done.

HTH.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/