Re: [PATCH] staging: iio: impedance-analyzer: ad5933: Change type in printf format string

[Jonathan Cameron]

On 27/01/15 22:18, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
Sorry, you were beaten to this one by Asaf Vertz a few weeks back.

Jonathan
> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index b6bd609..4230a43 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
>  	mutex_lock(&indio_dev->mlock);
>  	switch ((u32) this_attr->address) {
>  	case AD5933_OUT_RANGE:
> -		len = sprintf(buf, "%d\n",
> +		len = sprintf(buf, "%u\n",
>  			      st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
>  		break;
>  	case AD5933_OUT_RANGE_AVAIL:
> -		len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
> +		len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
>  			      st->range_avail[3], st->range_avail[2],
>  			      st->range_avail[1]);
>  		break;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/