Re: [E1000-devel] [PATCH] net:ethernet:intel:Remove outdated fix me comment in the function, gb_acquire_swfw_sync_i210

From: Jeff Kirsher
Date: Sun Feb 08 2015 - 20:26:16 EST


On Sun, 2015-02-08 at 17:21 -0800, Jeff Kirsher wrote:
> On Sun, 2015-02-08 at 00:21 -0500, Nicholas Krause wrote:
> > Removes the outdated fix me comment in the
> > function,gb_acquire_swfw_sync_i210
> > for setting the variables, i and timeout to the intended correct
> > values for
> > the function,gb_acquire_swfw_sync_i210 to function correctly. This
> > comment is
> > no longer due to these values having been no changed in the last few
> > years and
> > no known issues have been found for these variables being set to their
> > current
> > values. Due to this the comment can now be removed as the values set
> > for these
> > variables are known to be correct after years of no known issues or
> > bugs related
> > to their current values.
> >
> > Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
> > ---
> > drivers/net/ethernet/intel/igb/e1000_i210.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thank Nick, I will add your patch to my queue.

Oh and the title should be "igb: Remove outdated ...", not
"net:ethernet:intel: Remove ..."

Attachment: signature.asc
Description: This is a digitally signed message part