[PATCH] dm: fix multipath regression due to initializing wrong request
From: Mike Snitzer
Date: Mon Feb 09 2015 - 12:35:30 EST
On Mon, Feb 09 2015 at 12:13P -0500,
Mike Snitzer <snitzer@xxxxxxxxxx> wrote:
> On Mon, Feb 09 2015 at 12:07pm -0500,
> Keith Busch <keith.busch@xxxxxxxxx> wrote:
> > Oh, we're not going rebase the series with the correction? I'm concerned
> > someone biscecting a completely unrelated problem might step on this
> > commit. Up to you guys. It's my fault, so I'll deal with the consequences.
> Rebasing this late (3.20 merge already opened) is generally not done.
> Unfortunately we'll just have to suck it up and deal with the fallout
> during bisect -- would wager very few are bisecting with multipath as
> the focus of their test.
Jens and I discussed this further and given that linux-block breaks
dm-multipath it is best to fix linux-block and let Linus resolve the
merge when I send him the linux-dm pull.
Here is the patch to fix the regression:
From: Mike Snitzer <snitzer@xxxxxxxxxx>
Date: Mon, 9 Feb 2015 12:21:54 -0500
Subject: [PATCH] dm: fix multipath regression due to initializing wrong request
Commit febf715 ("block: require blk_rq_prep_clone() be given an
initialized clone request") introduced a regression by calling
blk_rq_init() on the original request rather than the clone
request that is passed to setup_clone().
Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
drivers/md/dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index f251633..71e6b73 100644
@@ -1719,7 +1719,7 @@ static int setup_clone(struct request *clone, struct request *rq,
- blk_rq_init(NULL, rq);
+ blk_rq_init(NULL, clone);
r = blk_rq_prep_clone(clone, rq, tio->md->bs, GFP_ATOMIC,
1.9.3 (Apple Git-50)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/