Re: [PATCH 1/2] hwrng: iproc-rng200 - Add Broadcom IPROC RNG driver

From: Joe Perches
Date: Mon Feb 09 2015 - 19:27:24 EST


On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
> This adds a driver for random number generator present on Broadcom
> IPROC devices.

trivia:

> diff --git a/drivers/char/hw_random/iproc-rng200.c b/drivers/char/hw_random/iproc-rng200.c
[]
> +static int iproc_rng200_probe(struct platform_device *pdev)
> +{
[]
> + if (!res) {
> + dev_err(dev, "failed to get rng resources");

Missing terminating newline:

dev_err(dev, "failed to get rng resources\n");

> + rng_base = devm_ioremap_resource(dev, res);
> + if (!rng_base) {
> + dev_err(dev, "failed to remap rng regs");

here too.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/