Re: 3.19: device name associates with IRQ's for ahci controllers operating with a single IRQ changed from "ahci?" to "<BDF>"

From: Stefan Bader
Date: Tue Feb 10 2015 - 02:58:04 EST


On 09.02.2015 20:54, Sander Eikelenboom wrote:
> Hi.
>
> In 3.19 the device name associates with IRQ's for ahci controllers operating
> with a single IRQ changed from "ahci?" to "<BDF>", was this intentional ?
>
> It's probably commit 18dcf433f3ded61eb140a55e7048ec2fef79e723 (or another one
> in that series).

Oh, looking at that commit that might make sense. In
ahci_host_activate_single_irq it now uses dev_driver_name instead of dev_name as
it did before (from ata_host_activate). The description sounds like before the
driver is registered this will return the bus. And registering an interrupt
would likely be before the driver is fully registered... But you probably saw
that, too. Whether that really was intentional is still the question. :)

-Stefan

>
> --
> Sander
>
>
> /proc/interrupts of an ahci controller with a single irq:
> 52: 13529 0 0 0 xen-pirq-msi 0000:00:1f.2
>
> /proc/interrupts of an ahci controller with multiple irq's:
> 114: 412535 0 0 0 0 0 xen-pirq-msi ahci0
> 115: 0 0 0 0 0 0 xen-pirq-msi ahci1
> 116: 16717 0 0 0 0 0 xen-pirq-msi ahci2
> 117: 0 0 0 0 0 0 xen-pirq-msi ahci3
> 118: 0 0 0 0 0 0 xen-pirq-msi ahci4
> 119: 0 0 0 0 0 0 xen-pirq-msi ahci5
>
>


Attachment: signature.asc
Description: OpenPGP digital signature