Re: [PATCH 1/2] dt-bindings: add disable-wakeup property for gpio-charger

[Mark Rutland]

On Tue, Feb 10, 2015 at 12:14:48PM +0000, Heiko StÃbner wrote:
> Am Dienstag, 10. Februar 2015, 12:00:30 schrieb Mark Rutland:
> > On Tue, Feb 10, 2015 at 08:12:24AM +0000, Chris Zhong wrote:
> > > add disable-wakeup for gpio-charger, if you set this property, system
> > > will not wakeup by gpio-charger.
> > > 
> > > Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
> > > ---
> > > 
> > >  Documentation/devicetree/bindings/power_supply/gpio-charger.txt | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt
> > > b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt index
> > > adbb5dc..a46e9bc 100644
> > > --- a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt
> > > +++ b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt
> > > 
> > > @@ -4,6 +4,7 @@ Required properties :
> > >   - compatible : "gpio-charger"
> > >   - gpios : GPIO indicating the charger presence.
> > >   
> > >     See GPIO binding in bindings/gpio/gpio.txt .
> > > 
> > > + - gpio-charger,disable-wakeup : Boolean, charger does not wake-up the
> > > system.
> > When would the system wake up otherwise?
> 
> a response for patch 2/2 suggested to move this to userspace (as deciding if 
> the charger should be a wakeup source is not a hardware property) and Chris 
> responded that he'll try to move it as suggested.

Great, that matches what I was thinking.

Thanks for taking the time to say this on the DT patch. 

Getting part of a series makes review far more painful :(

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/