Re: [PATCH] module: Annotate nested sleep in resolve_symbol()
From: Dave Jones
Date: Tue Feb 10 2015 - 12:51:03 EST
On Tue, Feb 10, 2015 at 06:12:55PM +0100, Peter Zijlstra wrote:
> On which, we should probably do this.
> Subject: module: Replace over-engineered nested sleep
> Since the introduction of the nested sleep warning; we've established
> that the occasional sleep inside a wait_event() is fine.
> wait_event() loops are invariant wrt. spurious wakeups, and the
> occasional sleep has a similar effect on them. As long as its occasional
> its harmless.
> Therefore replace the 'correct' but verbose wait_woken() thing with
> a simple annotation to shut up the warning.
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
Seems to suppress the warning, and modules still work.
Tested-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/