Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error
From: Dan Carpenter
Date: Wed Feb 11 2015 - 03:33:43 EST
On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote:
> >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter *adapt, u8 *powerlevel)
> >> ptr++;
> >> }
> >> }
> >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction,
> >> - &pwrtrac_value);
> >> + rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, &pwrtrac_value);
> > you are introducing one warning to fix one error. line over 80 character.
> Isn't that warning more of a guideline, rather than an actual warning?
You can't fight checkpatch.pl. We reject the worst or the worst "break
lines up into smaller chunks" patches where they obviously hurt
readability, but we almost always silence the warning in the end. The
original code in this case was fine.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/