Re: [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun()

From: David Miller
Date: Wed Feb 11 2015 - 17:34:09 EST


From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Date: Wed, 11 Feb 2015 11:23:38 +0100

> net/openvswitch/flow_netlink.c: In function ʽvalidate_and_copy_set_tunʼ:
> net/openvswitch/flow_netlink.c:1749: warning: ʽerrʼ may be used uninitialized in this function
>
> If ipv4_tun_from_nlattr() returns a different positive value than
> OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and
> validate_and_copy_set_tun() may return an undefined value instead of a
> zero success indicator. Initialize err to zero to fix this.
>
> Fixes: 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Applied.