Re: [PATCH 1/3] Slab infrastructure for array operations
From: David Rientjes
Date: Wed Feb 11 2015 - 19:35:24 EST
On Wed, 11 Feb 2015, Christoph Lameter wrote:
> > > > Hmm, not sure why the allocator would be required to do the
> > > > EXPORT_SYMBOL() if it defines kmem_cache_free_array() itself. This
> > >
> > > Keeping the EXPORT with the definition is the custom as far as I could
> > > tell.
> > >
> > If you do dummy functions for all the allocators, then this should be as
> > simple as unconditionally defining kmem_cache_free_array() and doing
> > EXPORT_SYMBOL() here and then using your current implementation of
> > __kmem_cache_free_array() for mm/slab.c.
> That works if I put an EXPORT_SYMBOL in mm/slab_common.c and define the
> function in mm/slub.c?
No, my suggestion was for the same pattern as kmem_cache_alloc_array().
In other words, I think you should leave the definition of
kmem_cache_free_array() the way it is in your patch, remove the #ifndef
since _HAVE_SLAB_ALLOCATOR_ARRAY_OPERATIONS is going away, and then define
a __kmem_cache_free_array() for each allocator.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/